Re: [PATCH] irda: missing allocation result check in irlap_change_speed()

David Miller wrote:
> If the allocation fails we should probably do something
> more interesting here, such as schedule a timer to try
> again later.  Otherwise the speed change will silently
> never occur.
>   
I thought the speed change would be piggybacked on the next frame, same
as when 'now' == 0. Is that not the case?

	self->speed = speed;

	/* Change speed now, or just piggyback speed on frames */
	if (now) {
		/* Send down empty frame to trigger speed change */
		skb = dev_alloc_skb(0);
		if (skb)
			irlap_queue_xmit(self, skb);
	}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] irda: missing allocation result check in irlap_change_speed()
    • From: Florin Malita <[email protected]>
  • Re: [PATCH] irda: missing allocation result check in irlap_change_speed()
    • From: David Miller <[email protected]>

• Prev by Date: [-mm PATCH] time: fix time going backward w/ clock=pit
• Next by Date: Re: How to check if kernel sources are installed on a system?
• Previous by thread: Re: [PATCH] irda: missing allocation result check in irlap_change_speed()
• Next by thread: [PATCH 0/3] avoid pci_find_device
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]