Re: [PATCH 1/2] request_firmware without a device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 25, 2006 at 12:26:21PM +0200, Marcel Holtmann wrote:
> Hi Shaohua,
> 
> > > > The patch allows calling request_firmware without a 'struct device'.
> > > > It appears we just need a name here from 'struct device'. I changed it
> > > > to use a kobject as Patrick suggested.
> > > > Next patch will use the new API to request firmware (microcode) for a CPU.
> > > 
> > > But a cpu does have a struct device.  Why not just use that?
> > It's a sysdev, no 'struct device' in it, IIRC.
> 
> do we really need to differentiate between sysdev and device anymore. I
> recall a plan to unify all devices, but I might be wrong.

I don't think we need to keep them different anymore, they should be
made the same.  Then issues like this will not happen.

And it will make your driver code smaller :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux