Re: [UPDATE][7/24]several messages

[Jan Engelhardt <jengelh@linux01.gwdg.de>]

>Summary of this patch:
>  [7/24]  modify format strings in print(bfs)
>          - As i_blocks of VFS inode gets 8 byte variable, change its
>            string format to %lld.
>
>-        if (inode->i_size || inode->i_blocks) dprintf("Registered inode with %lld size, %ld blocks\n", inode->i_size, inode->i_blocks);
>+        if (inode->i_size || inode->i_blocks) dprintf("Registered inode with %lld size, %lld blocks\n", inode->i_size, inode->i_blocks);

Does gcc automatically promote/demote the arguments according to the % 
specifier? Otherwise, you should add an explicit cast to (long) or 
(long long) with varargs functions, since you cannot be sure that 
->i_blocks (blkcnt_t) is the same as long/long long.

>Summary of this patch:
>  [8/24]  modify format strings in print(efs)
>          - As i_blocks of VFS inode gets 8 byte variable, change its
>            string format to %lld.
>
>@@ -22,7 +22,7 @@ int efs_get_block(struct inode *inode, s
> 		/*
> 		 * i have no idea why this happens as often as it does
> 		 */
>-		printk(KERN_WARNING "EFS: bmap(): block %d >= %ld (filesize %ld)\n",
>+		printk(KERN_WARNING "EFS: bmap(): block %d >= %lld (filesize %ld)\n",



Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/