Re: [PATCH] Per-superblock unused dentry LRU lists V2

[Balbir Singh <balbir@in.ibm.com>]

On Thu, May 25, 2006 at 04:33:50PM +1000, David Chinner wrote:
> On Thu, May 25, 2006 at 04:15:53PM +1000, David Chinner wrote:
> > On Thu, May 25, 2006 at 09:36:04AM +0530, Balbir Singh wrote:
> > > > +/*
> > > > + * Shrink the dentry LRU on æ given superblock.
> > > 			      ^^^
> > > This character (ae) looks strange.
> > 
> > Fixed. It slipped through when I switched to the -mm tree.
> > 
> > > The other changes look fine. Do you have any performance numbers, any
> > > results from stress tests (for version 2 of the patch)?
> > 
> > Not yet - I've just started the stress tests now. I had to wait for
> > the storage and then reconfigure it which took some time.  It's
> > currently running a create/unlink workload across 8 filesystems in
> > parallel.  I'll run some dbench loads after this has run for a few
> > hours.
> > 
> > FWIW, this create/unlink load has been triggering reliable "Busy
> > inodes after unmount" errors that I've slowly been tracking down.
> > After I fixed the last problem in XFS late last week, I've
> > been getting a failure that i think is the unmount/prune_dcache
> > races that you and Neil have recently fixed.
> 
> I just had all 8 filesystems come up with:
> 
> May 25 15:55:18 budgie kernel: XFS unmount got error 16
> May 25 15:55:18 budgie kernel: xfs_fs_put_super: vfsp/0xe00000b006339280 left dangling!
> May 25 15:55:18 budgie kernel: VFS: Busy inodes after unmount of dm-9. Self-destruct in 5 seconds.  Have a nice day...
> May 25 15:55:19 budgie kernel: XFS: Invalid device [/dev/mapper/dm8], error=-16
> May 25 15:55:35 budgie kernel: XFS unmount got error 16
> May 25 15:55:35 budgie kernel: xfs_fs_put_super: vfsp/0xe000003015a18c80 left dangling!
> May 25 15:55:35 budgie kernel: VFS: Busy inodes after unmount of dm-15. Self-destruct in 5 seconds.  Have a nice day...
> May 25 15:55:35 budgie kernel: XFS unmount got error 16
> May 25 15:55:35 budgie kernel: xfs_fs_put_super: vfsp/0xe000003015ea6280 left dangling!
> May 25 15:55:35 budgie kernel: VFS: Busy inodes after unmount of dm-13. Self-destruct in 5 seconds.  Have a nice day...
> May 25 15:55:36 budgie kernel: XFS: Invalid device [/dev/mapper/dm14], error=-16
> May 25 15:55:36 budgie kernel: XFS: Invalid device [/dev/mapper/dm12], error=-16
> May 25 15:55:42 budgie kernel: XFS unmount got error 16
> May 25 15:55:42 budgie kernel: xfs_fs_put_super: vfsp/0xe00000b00633b580 left dangling!
> May 25 15:55:42 budgie kernel: VFS: Busy inodes after unmount of dm-5. Self-destruct in 5 seconds.  Have a nice day...
> May 25 15:55:44 budgie kernel: XFS: Invalid device [/dev/mapper/dm4], error=-16
> May 25 15:55:44 budgie kernel: XFS unmount got error 16
> May 25 15:55:44 budgie kernel: xfs_fs_put_super: vfsp/0xe00000b00633bc80 left dangling!
> May 25 15:55:44 budgie kernel: VFS: Busy inodes after unmount of dm-11. Self-destruct in 5 seconds.  Have a nice day...
> May 25 15:55:44 budgie kernel: XFS: Invalid device [/dev/mapper/dm10], error=-16
> May 25 15:55:55 budgie kernel: XFS unmount got error 16
> May 25 15:55:55 budgie kernel: xfs_fs_put_super: vfsp/0xe000003015d4a080 left dangling!
> May 25 15:55:55 budgie kernel: VFS: Busy inodes after unmount of dm-7. Self-destruct in 5 seconds.  Have a nice day...
> May 25 15:55:56 budgie kernel: XFS: Invalid device [/dev/mapper/dm6], error=-16
> May 25 15:56:16 budgie kernel: XFS unmount got error 16
> May 25 15:56:16 budgie kernel: xfs_fs_put_super: vfsp/0xe00000b9edeacf80 left dangling!
> May 25 15:56:16 budgie kernel: VFS: Busy inodes after unmount of dm-3. Self-destruct in 5 seconds.  Have a nice day...
> May 25 15:56:16 budgie kernel: XFS unmount got error 16
> May 25 15:56:16 budgie kernel: xfs_fs_put_super: vfsp/0xe000003015a2a280 left dangling!
> May 25 15:56:16 budgie kernel: VFS: Busy inodes after unmount of dm-1. Self-destruct in 5 seconds.  Have a nice day...
> 
> On the second test iteration. On 2.6.16, it takes about 10 iterations to get one
> filesystem to do this. I'll need to look into this one further. I'm going to
> reboot the machine and run some dbench tests (which typically don't trigger
> this problem) and then come back to this one with added debugging....
>

Is this with version 2 of your patch? Could you also try the -mm tree
and see if the problem goes away. We have a set of patches to address
exactly this problem. 

	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/