Re: [patch] initialize variables in fs/isofs/namei.c

On Sun, 21 May 2006, Dave Jones wrote:

On Sun, May 21, 2006 at 03:02:34PM -0400, Ameer Armaly wrote:
> This patch removes un-initialized variable warnings for block and offset in
> namei.c, which are later initialized through a call to isofs_find_entry().

Which indicates the problem lies with gcc, just like with the other patches
'fixing' these warnings.

I agree. The compiler should be smart enough to at least consider the possibility of initializing through pointers.

The warning is bogus.

It is, but at the same it's clutter; in my opinion, readability is not impacted by explicitly initializing variables that get initialized through a pointer, and we reduce annoying make output.

 > 		Dave

--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch] initialize variables in fs/isofs/namei.c
    • From: Ameer Armaly <[email protected]>
  • Re: [patch] initialize variables in fs/isofs/namei.c
    • From: Dave Jones <[email protected]>

• Prev by Date: Re: AMD 8131 MSI quirk called too late, bus_flags not inherited ?
• Next by Date: Re: [PATCH] Documentation update for kdump
• Previous by thread: Re: [patch] initialize variables in fs/isofs/namei.c
• Next by thread: [patch] fs warning fixes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]