Re: + x86-move-vsyscall-page-out-of-fixmap-above-stack-tidy.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Wedgwood <[email protected]> wrote:
>
> On Sun, May 21, 2006 at 02:51:54AM -0700, [email protected] wrote:
> 
> > -	if ((ret = insert_vm_struct(mm, vma))) {
> > +	ret = insert_vm_struct(mm, vma);
> > +	if (ret) {
> 
> Urgh.
> 
> It's not really any cleaner/clearer so why do that?
>

Because it's cleaner and clearer and because Linus said.

One is an assignment and the other is a test.  These have nothing to do
with each other.

Keep it simple.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux