Hi!
> > > > > @@ -420,7 +421,14 @@ void zap_low_mappings (void)
> > > > > #else
> > > > > set_pgd(swapper_pg_dir+i, __pgd(0));
> > > > > #endif
> > > > > - if (cpus_weight(cpu_online_map) == 1)
> > > > > + /*
> > > > > + * We can be called at suspend/resume time, with local interrupts
> > > > > + * disabled. But flush_tlb_all() requires that local interrupts be
> > > > > + * enabled.
> > > > > + *
> > > > > + * Happily, the APs are not yet started, so we can use local_flush_tlb() * in that case
> > > > > + */
> > > > > + if (num_online_cpus() == 1)
> > > > > local_flush_tlb();
> > > > > else
> > > > > flush_tlb_all();
> > > >
> > > > But this still scares. It means calling convention is "may enable
> > > > interrupts with >1 cpu, may not with == 1 cpu".
> > > Below patch should make things clean. How do you think?
> >
> > Nice...
> >
> > Could we perhaps reuse swsusp_pg_dir (just make it used for swsusp &
> > suspend-to-ram) to save a bit more code? It is in arch/i386/mm/init.c
> Ok, I guess this is what you want.
Yes, thanks a lot for patience.
> Signed-off-by: Shaohua Li <[email protected]>
Acked-by: Pavel Machek <[email protected]>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]