Re: [PATCH 1/6] nfs: "open code" the NFS direct write rescheduler

Chuck Lever <[email protected]> wrote:
>
> +	 * Prevent I/O completion while we're still rescheduling
> +	 */
> +	dreq->outstanding++;
> +

No locking.

>  	dreq->count = 0;
> +	list_for_each(pos, &dreq->rewrite_list) {
> +		struct nfs_write_data *data =
> +			list_entry(dreq->rewrite_list.next, struct nfs_write_data, pages);
> +
> +		spin_lock(&dreq->lock);
> +		dreq->outstanding++;
> +		spin_unlock(&dreq->lock);

Locking.

Deliberate?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/6] nfs: "open code" the NFS direct write rescheduler
    • From: Chuck Lever <[email protected]>

• References:
  • [PATCH 0/6] Support scatter/gather I/O in NFS direct I/O path
    • From: Chuck Lever <[email protected]>
  • [PATCH 1/6] nfs: "open code" the NFS direct write rescheduler
    • From: Chuck Lever <[email protected]>

• Prev by Date: Re: [PATCH 2/2] ufs: directory and page cache: from blocks to pages
• Next by Date: Re: [RFC][PATCH] MD RAID Acceleration: Move stripe operations outside the spin lock
• Previous by thread: [PATCH 1/6] nfs: "open code" the NFS direct write rescheduler
• Next by thread: Re: [PATCH 1/6] nfs: "open code" the NFS direct write rescheduler
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]