Re: [RFC][-rt PATCH] Try to safely error out when mixing pi/non-pi futex operations on the same futex.

* john stultz <[email protected]> wrote:

> Ingo,
> 	We've been seeing some oopses because there are waiters on pi 
> futexes that do not have pi_states. This seems to be because they were 
> used w/ futex_wait in one path and futex_lock_pi in another.

indeed, that's a bug.

> I'm told this shouldn't ever happen, but if it did, the kernel should 
> safely error out, instead of oopsing or never releasing a lock.
> 
> Not sure if this is a solid fix (it does build and boot), but 
> hopefully it will stir up some discussion.

applied. I made some small fixes: i made the printk rate-limited and 
dependent on CONFIG_DEBUG_RT_MUTEXES. The right thing is indeed to 
-EINVAL.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [RFC][-rt PATCH] Try to safely error out when mixing pi/non-pi futex operations on the same futex.
  - From: john stultz <[email protected]>

Prev by Date: Re: [PATCH -rt] scheduling while atomic in fs/file.c
Next by Date: Re: [PATCH -rt] free_pgtables deadlock
Previous by thread: [RFC][-rt PATCH] Try to safely error out when mixing pi/non-pi futex operations on the same futex.
Next by thread: [PATCH 1/2] list: introduce list_replace() helper
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]