Re: [PATCH] mm: cleanup swap unused warning

On Thursday 11 May 2006 09:04, Christoph Lameter wrote:
> On Wed, 10 May 2006, Con Kolivas wrote:
> > Are there any users of swp_entry_t when CONFIG_SWAP is not defined?
>
> Yes, a migration entry is a form of swap entry.

mm/vmscan.c: In function ‘remove_mapping’:
mm/vmscan.c:387: warning: unused variable ‘swap’

Ok so if we fix it by making swp_entry_t __attribute__((__unused__) we break 
swap migration code?

If we make swap_free() an empty static inline function then gcc compiles in 
the variable needlessly and we won't know it.

For the moment let's continue putting up with the warning.

-- 
-ck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] mm: cleanup swap unused warning
    • From: Christoph Lameter <[email protected]>
  • [PATCH] mm: cleanup swap unused warning
    • From: Con Kolivas <[email protected]>

• References:
  • [PATCH] mm: cleanup swap unused warning
    • From: Con Kolivas <[email protected]>
  • Re: [PATCH] mm: cleanup swap unused warning
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: KERNEL: assertion (!sk->sk_forward_alloc) failed at net/* (again)
• Next by Date: Re: KERNEL: assertion (!sk->sk_forward_alloc) failed at net/* (again)
• Previous by thread: Re: [PATCH] mm: cleanup swap unused warning
• Next by thread: [PATCH] mm: cleanup swap unused warning
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]