Re: [PATCH] tcpdump may trace some outbound packets twice.

From: Ranjit Manomohan <[email protected]>
Date: Mon, 15 May 2006 14:19:06 -0700 (PDT)

> Heres a new version which does a copy instead of the clone to avoid
> the double cloning issue.

I still very much dislike this patch because it is creating
1 more clone per packet than is actually necessary and that
is very expensive.

dev_queue_xmit_nit() is going to clone whatever SKB you send into
there, so better to just bump the reference count (with skb_get())
instead of cloning or copying.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] tcpdump may trace some outbound packets twice.
  - From: Ranjit Manomohan <[email protected]>
- Re: [PATCH] tcpdump may trace some outbound packets twice.
  - From: Patrick McHardy <[email protected]>

References:
- Re: [PATCH] tcpdump may trace some outbound packets twice.
  - From: Andrew Morton <[email protected]>
- Re: [PATCH] tcpdump may trace some outbound packets twice.
  - From: "David S. Miller" <[email protected]>
- Re: [PATCH] tcpdump may trace some outbound packets twice.
  - From: Ranjit Manomohan <[email protected]>

Prev by Date: Re: 2.6.17-rc1: kernel only boots one CPU on HT system
Next by Date: Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt
Previous by thread: Re: [PATCH] tcpdump may trace some outbound packets twice.
Next by thread: Re: [PATCH] tcpdump may trace some outbound packets twice.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]