Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt

On Mon, 2006-05-15 at 08:50 -0700, Roland Dreier wrote:

> Actually I NAK'ed this patch.  It compiles the same thing on x86_64
> but makes the source code wrong -- dma_map_single() returns a bus
> address, not a physical address.

As Segher mentioned, bus_to_virt is unportable, so it's definitely the
wrong thing to use.

I don't recall what you suggested instead, but I seem to recall that the
discussion kind of went "oh, right, the layering is all broken".

Any ideas?  Should this turn from a one-liner into a
big-refactor-for-2.6.18 patch?

	<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt
    • From: Roland Dreier <[email protected]>

• References:
  • [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt
    • From: Roland Dreier <[email protected]>

• Prev by Date: [PATCH 3/4] Core aio changes to support vectored AIO
• Next by Date: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
• Previous by thread: Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt
• Next by thread: Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]