Re: [PATCH] 2.6.17-rc4-mm1 - kbuild wierdness with EXPORT_SYMBOL_GPL

[Ram Pai <linuxram@us.ibm.com>]

On Mon, 2006-05-15 at 15:00 -0400, Valdis.Kletnieks@vt.edu wrote:
> It looks like a buggy comparison down in the guts of
> kbuild-export-type-enhancement-to-modpostc.patch - it's doing
> something really odd when it hits a EXPORT_SYMBOL_GPL.
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> ---
> Proposed fix (with an added debugging warning Just In Case:
> 
> --- linux-2.6.17-rc4-mm1/scripts/mod/modpost.c.whatdied	2006-05-15 13:50:13.000000000 -0400
> +++ linux-2.6.17-rc4-mm1/scripts/mod/modpost.c	2006-05-15 14:52:13.000000000 -0400
> @@ -1194,12 +1194,14 @@
>  					*d != '\0')
>  			goto fail;
>  
> -		if ((strcmp(export, "EXPORT_SYMBOL_GPL")))
> +		if ((strcmp(export, "EXPORT_SYMBOL_GPL") == 0))

Yes my mistake.  Error while merging in Andreas's fix. :(

Andrew, can apply this patch on top of the other patches?
RP



>  			export_type = 1;
>  		else if(strcmp(export, "EXPORT_SYMBOL") == 0)
>  			export_type = 0;
> -		else
> +		else {
> +			warn("Odd symbol export=%s symname=%s modname=%s\n",export,symname,modname);
>  			goto fail;
> +		}
>  
>  		if (!(mod = find_module(modname))) {
>  			if (is_vmlinux(modname)) {
> 
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/