Re: 2.6.15-rc1: IDE: fix potential data corruption with SL82C105 interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Alan Cox wrote:
On Llu, 2006-05-15 at 18:32 +0400, Sergei Shtylyov wrote:

Heh, this driver also tries to cache the single PCI register per-channel like hpt366.c... This buglet concerns using fast PIO timings and is probably harmless though but needs to be fixed -- I'll send a patch soon...
   I wonder what is otherwise wrong with using 2 channels concurrently?

I've not got any dual channel devices to test, and in fact I couldn't
find anyone with dual channel stuff at all.

Hm, I thought they're all dual channel, at least from W83C553F docs. We have this chip on several embedded boards -- I'll try to gain access to one of them when I get to this driver...

The caching is one bug, the
fact the reset hits both channels is the other I know about.

Ah, that register 0x7E reset? Strangely, W83C55[34]F datasheets don't even mention it. :-/

Otherwise the libata driver is fairly similar

   Found it, looking...

although the timing is
pre-computed from the documentation for the DMA modes.

As these chips lack 66 MHz PCI support, this should be quite enough, I think... :-)

MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux