Re: [PATCH 53 of 53] ipath - add memory barrier when waiting for writes

 >  static void i2c_wait_for_writes(struct ipath_devdata *dd)
 >  {
 > +	mb();
 >  	(void)ipath_read_kreg32(dd, dd->ipath_kregs->kr_scratch);
 >  }

This needs a comment explaining why it's needed.  A memory barrier
before a readl() looks very strange since readl() should be ordered anyway.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 53 of 53] ipath - add memory barrier when waiting for writes
  - From: "Bryan O'Sullivan" <[email protected]>

References:
- [PATCH 53 of 53] ipath - add memory barrier when waiting for writes
  - From: "Bryan O'Sullivan" <[email protected]>

Prev by Date: Re: Rlimit
Next by Date: Re: [PATCH 50 of 53] ipath - reduce maximum table sizes
Previous by thread: [PATCH 53 of 53] ipath - add memory barrier when waiting for writes
Next by thread: Re: [PATCH 53 of 53] ipath - add memory barrier when waiting for writes
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]