On 5/15/06, Oliver Neukum <[email protected]> wrote:
Am Montag, 15. Mai 2006 10:49 schrieb [email protected]:
> +urb->status = 0;
> +urb->actual_length = 0;
These are not needed. Indeed you should never write to those fields.
Regards
Oliver
I see. Good point. I ought to have actually looked at usb_submit_urb
and seen that it initializes status and actual_length. I'll make the
change.
To reduce my embarrassment, I'll point out that several other media
drivers also do this:
drivers/usb/media % egrep "urb->status.*=" *.c
<snip>
konicawc.c: urb->status = 0;
se401.c: urb->status=0;
stv680.c: urb->status = 0;
usbvideo.c: urb->status = 0;
w9968cf.c: urb->status = 0;
In most of the above cases, it appears to be just before resubmitting the urb.
Thanks,
jaya
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
