Re: [PATCH] fix dangerous pointer derefs and remove pointless casts in MOXA driver

On Sun, May 14, 2006 at 03:49:35AM +0200, Jesper Juhl wrote:
> If mxser_write() gets called with a NULL 'tty' pointer, then the initial
> assignment of tty->driver_data to info will explode.

If mxser_write gets called with a NULL pointer then you've already got such
serious problems it isn't worth checking

> Please consider for inclusion.

Just delete the checks.  Also the little cast cleanup looks good so submit
that as a separate patch too.

Alan


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix dangerous pointer derefs and remove pointless casts in MOXA driver
    • From: "Jesper Juhl" <[email protected]>

• References:
  • [PATCH] fix dangerous pointer derefs and remove pointless casts in MOXA driver
    • From: Jesper Juhl <[email protected]>

• Prev by Date: GPL and NON GPL version modules
• Next by Date: Bug related to bonding
• Previous by thread: Re: [PATCH] fix dangerous pointer derefs and remove pointless casts in MOXA driver
• Next by thread: Re: [PATCH] fix dangerous pointer derefs and remove pointless casts in MOXA driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]