Re: [Alsa-devel] [PATCH] Fix a memory leak in pdaudiocf

At Sat, 13 May 2006 23:44:25 +0200,
Jesper Juhl wrote:
> 
> There's a potential memory leak in 
> sound/pcmcia/pdaudiocf/pdaudiocf.c::pdacf_config()
> 
> If we leave via one of the *failed: labels we may leak 'parse', so add a 
> kfree(parse) to the end of the function and also make sure to set 'parse' 
> to NULL after the kfree() call a little further up so we don't do a 
> double-free of the pointer if we hit one of the *failed: labels after the 
> first kfree().
> 
> Since I don't have the hardware I can't test the patch beyond making sure 
> it compiles cleanly, but I feel pretty confident that it is correct.
> 
> Please consider for inclusion.

This bug was already fixed in a different way on ALSA HG repo.

thanks,

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix a memory leak in pdaudiocf
    • From: Jesper Juhl <[email protected]>

• Prev by Date: [PATCH -mm 01/02] Update rt-mutex-design.txt per Randy Dunlap
• Next by Date: [PATCH -mm 02/02] Update rt-mutex-design.txt per Randy Dunlap
• Previous by thread: [PATCH] Fix a memory leak in pdaudiocf
• Next by thread: [PATCH] fix (unlikely) memory leak in DAC960 driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]