Re: [PATCH][resend] fix resource leak in pnp card_probe()

On 14/05/06, Andrew Morton <[email protected]> wrote:

Jesper Juhl <[email protected]> wrote:
>
> (resend of patch already send once on 23/03-2006
>   - still applies cleanly to latest -git)
>
>
> We can leak `clink' in drivers/pnp/card.c::card_probe()
>

[snip]

If !drv->probe then there's not much point in doing the kmalloc and then
immediately freeing it again.

True. It was simply the simplest and least intrusive fix I could make.

Like this?

Looks good to me, thanks.

[snip neater version of fix]


--
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH][resend] fix resource leak in pnp card_probe()
    • From: Jesper Juhl <[email protected]>
  • Re: [PATCH][resend] fix resource leak in pnp card_probe()
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] tcpdump may trace some outbound packets twice.
• Next by Date: RPC in kernel space
• Previous by thread: Re: [PATCH][resend] fix resource leak in pnp card_probe()
• Next by thread: Re: [PATCH][resend] fix resource leak in pnp card_probe()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]