On 14/05/06, David Woodhouse <[email protected]> wrote:
On Sun, 2006-05-14 at 01:07 +0200, Jesper Juhl wrote:
> There are two code paths in drivers/mtd/devices/phram.c::phram_setup() that
> will leak memory.
> Memory is allocated to the variable 'name' with kmalloc() by the
> parse_name() function, but if we leave by way of the parse_err() macro,
> then that memory is never kfree()'d, nor is it ever used with
> register_device() so it won't be freed later either - leak.
>
> Found by the Coverity checker as #593 - simple fix below.
Applied; thanks. Please Cc me and/or [email protected] on
MTD patches.
Sure thing, will do. The same problem exists in
drivers/mtd/devices/block2mtd.c, I'm cooking up a patch for that one
as we speak.
(Ew. The parse_err() macro contains a 'return'. Who do I slap for that?)
Want me to fix the macro and the users of it?
--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
