Re: [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives

On 13/05/06, Catalin Marinas <[email protected]> wrote:

From: Catalin Marinas <[email protected]>

There are allocations for which the main pointer cannot be found but they
are not memory leaks. This patch fixes some of them.

[snip]

+#ifdef CONFIG_DEBUG_MEMLEAK
+               /* avoid a false alarm. That's not a memory leak */
+               memleak_free(out);
+#endif

Hmm, so eventually we are going to end up with a bunch of ugly #ifdef
CONFIG_DEBUG_MEMLEAK's all over the place?

Wouldn't it be better to just make memleak_free() an empty stub in the
!CONFIG_DEBUG_MEMLEAK case?

--
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives
    • From: Catalin Marinas <[email protected]>

• References:
  • [RFC PATCH 2.6.17-rc4 0/6] Kernel memory leak detector
    • From: Catalin Marinas <[email protected]>
  • [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives
    • From: Catalin Marinas <[email protected]>

• Prev by Date: Re: [stable] Re: [patch] smbus unhiding kills thermal management
• Next by Date: [PATCH] kfree without virt_to_page()
• Previous by thread: [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives
• Next by thread: Re: [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]