Re: [PATCH 4/6] myri10ge - First half of the driver

Brice Goglin <[email protected]> :
[...]
> > Return in a middle of a spinlock-intensive function. :o(
> >   
> 
> What do you mean ?

It is preferred for maintenance purpose (hello Mr Morton) to organize
the control flow with a single spin_{lock/unlock} pair: if there is a
branch in the control flow, it ought to be joined again before returning.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/6] myri10ge - Myri-10G Ethernet driver
    • From: Brice Goglin <[email protected]>
  • [PATCH 4/6] myri10ge - First half of the driver
    • From: Brice Goglin <[email protected]>
  • Re: [PATCH 4/6] myri10ge - First half of the driver
    • From: Francois Romieu <[email protected]>
  • Re: [PATCH 4/6] myri10ge - First half of the driver
    • From: Brice Goglin <[email protected]>

• Prev by Date: [PATCH 2.6.17-rc4 5/6] Add kmemleak support for ARM
• Next by Date: Re: C++ pushback
• Previous by thread: Re: [PATCH 4/6] myri10ge - First half of the driver
• Next by thread: Re: [PATCH 4/6] myri10ge - First half of the driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]