Thomas Kleffel (maintech GmbH) wrote:
>
> +void outb_io(unsigned char value, unsigned long port) {
> + outb(value, port);
> +}
> +
> +void outb_mem(unsigned char value, unsigned long port) {
> + writeb(value, (void __iomem *) port);
> }
[...]
> + if(is_mmio)
> + my_outb = outb_mem;
> + else
> + my_outb = outb_io;
Shouldn't you convert ide_cs to use iowrite8 (and friends) instead of
doing this?
David Vrabel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available (2nd revision)
- From: "Thomas Kleffel (maintech GmbH)" <[email protected]>
- Re: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available (2nd revision)
- References:
- [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available
- From: "Thomas Kleffel (maintech GmbH)" <[email protected]>
- Re: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available
- From: Alan Cox <[email protected]>
- Re: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available (2nd revision)
- From: "Thomas Kleffel (maintech GmbH)" <[email protected]>
- [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available
- Prev by Date: Re: rt20 patch question
- Next by Date: Re: rt20 patch question
- Previous by thread: Re: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available (2nd revision)
- Next by thread: Re: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available (2nd revision)
- Index(es):
 |