Re: [PATCH] dl2k: use explicit DMA_48BIT_MASK

Jon Mason <[email protected]> :
[...]
> DMA_*BIT_MASK is intended to be used in the DMA_API's checking of
> DMA controller's addressable memory, where as this is masking off the
> lower 48bits of a descriptor for its DMA address.  

Imho it's the specific reason why the DMA_*BIT_MASK applies here: the
code is already in dma-"tainted" land.

> I think a better solution (which I should've done when I pushed the
> original patch) would be a driver specific #define.  

$ find drivers -type f | xargs grep -i [^f]ffffffffffff[^f] | wc -l
12

No disagreement: it does not have a huge potential for code duplication.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH -mm] updated dl2k gcc 4.1 warning fix
    • From: Daniel Walker <[email protected]>
  • [PATCH] dl2k: use explicit DMA_48BIT_MASK
    • From: Francois Romieu <[email protected]>
  • Re: [PATCH] dl2k: use explicit DMA_48BIT_MASK
    • From: Jon Mason <[email protected]>

• Prev by Date: Re: Oops in au8830 driver on x86-64
• Next by Date: Re: [PATCH 1/4] Vectorize aio_read/aio_write methods
• Previous by thread: Re: [PATCH] dl2k: use explicit DMA_48BIT_MASK
• Next by thread: OOPS during FC-aware-driver module reload...
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]