Re: fix compiler warning in ip_nat_standalone.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 11 May 2006 17:18:46 +0100, Al Viro wrote:
> On Thu, May 11, 2006 at 05:55:37PM +0200, J?rn Engel wrote:
> > 
> > You cannot fix a compiler warning!
> > 
> > Either the code is wrong or it is right.  A compiler warning can
> > indicate that code is wrong, or it is a false positive.  If the code
> > is wrong, fix the _code_.
> 
> Which is what the patch does, AFAICS.  What's the problem in this case?

See subject.  I didn't object to the patch, that looked fine to me.
But the general idea that a warning can be fixed always hits a loose
nerve in my brain.  Maybe I'm a bit silly in this respect.

Jörn

-- 
When in doubt, use brute force.
-- Ken Thompson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux