Re: [RFC] [PATCH] Execute PCI quirks on resume from suspend-to-RAM

[Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>]

Greg KH wrote:
> On Wed, May 10, 2006 at 12:30:34PM +0200, Carl-Daniel Hailfinger wrote:
>> Thinking about it again, if we restored the full pci config space
>> on resume, this quirk handling would be completely unnecessary.
>> Any reasons why we don't do that?
> 
> We do do that.  Look at pci_restore_state().
> 
> Actually, look at it in the latest -mm tree, that version works better
> than mainline does right now :)

Sorry. Even the version in -mm does not restore all 256 bytes, so it
will not change anything. The quirk sits at offset 0xf2 in config space.
So either we really restore the full config space (probably a good idea
by itself) or we add the quirk handling to the suspend-to-ram codepath.

On a related note, what happens if we try to restore the config space of
a device which has vanished? Right now this happens on all mainboards
with asus_hides_smbus==1 during resume-from-ram.

Greg, do you have any comments on the patch starting this thread?

Regards,
Carl-Daniel
-- 
http://www.hailfinger.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/