Re: [PATCH -mm] riva CalcStateExt gcc 4.1 warning fix

On Maw, 2006-05-09 at 19:56 -0700, Daniel Walker wrote:
> This could be a bug. The return from CalcVClock isn't checked
> so the variables in questions could be random data ..
> 
> Fixes the following warning,
> 
> drivers/video/riva/riva_hw.c: In function 'CalcStateExt':
> drivers/video/riva/riva_hw.c:1241: warning: 'p' may be used uninitialized in this function
> drivers/video/riva/riva_hw.c:1241: warning: 'n' may be used uninitialized in this function
> drivers/video/riva/riva_hw.c:1241: warning: 'm' may be used uninitialized in this function
> drivers/video/riva/riva_hw.c:1241: warning: 'VClk' may be used uninitialized in this function

But zero isn't valid data. You need to fix the missing return check not
hide the warnings. This goes for just about every patch in this series

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH -mm] riva CalcStateExt gcc 4.1 warning fix
    • From: Daniel Walker <[email protected]>

• Prev by Date: Re: [PATCH -mm] sys_semctl gcc 4.1 warning fix
• Next by Date: [PATCH][delayacct] Add comments on units for the delay fields (was Re: [Patch 2/8] Sync block I/O and swapin delay collection)
• Previous by thread: [PATCH -mm] riva CalcStateExt gcc 4.1 warning fix
• Next by thread: [PATCH -mm] sys_msgctl gcc 4.1 warning fix
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]