Re: [PATCH]x86_64 debug_stack nested patch

["bibo,mao" <bibo_mao@linux.intel.com>]

yes, I am wrong. And I will modify this. And then only need define 
DEBUG_STACK_ORDER as (EXCEPTION_STACK_ORDER + 1)

thanks
bibo,mao

Jan Beulich wrote:
> > in_exception_stack() function is to judge which IST stack by parameter 
> > stack value, if DEBUG_STKSZ value is set as 8K. The original function 
> > can not judge whether it is within DEBUG_STACK space.
>
> I rather think that the new code can't work properly. Since the pointer in the TSS gets decreased while the handler is
> running, using that value is not going to tell you the end of the stack, but you'd rather get the end of the stack the
> next (nested) invocation of the handler would use. Further, treating the entire DEBUG_STKSZ range as a single piece is
> wrong, too, because it is not being used as a contiguous stack (but rather as 2 stacks EXCEPTION_STKSZ in size); the new
> code shouldn't be able to properly deal with nested invocations because of this.
>
> Jan
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/