Re: [RFC PATCH 04/35] Hypervisor interface header files.

Hi Chris,

first of all: Thanks to the Xen-Team for doing this!

On Tuesday, 9. May 2006 09:00, Chris Wright wrote:
> Define macros and inline functions for doing hypercalls into the
> hypervisor.
> +static inline int
> +HYPERVISOR_set_trap_table(
> +	struct trap_info *table)
> +{
> +	return _hypercall1(int, set_trap_table, table);
> +}

This is outright ugly and non-conformant to 
Documentation/CodingStyle Chapter 2

Fixing this also saves some code lines.

It also looks like generated code. Maybe you can fix your generator
instead?


Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC PATCH 04/35] Hypervisor interface header files.
    • From: Chris Wright <[email protected]>

• References:
  • [RFC PATCH 00/35] Xen i386 paravirtualization support
    • From: Chris Wright <[email protected]>
  • [RFC PATCH 04/35] Hypervisor interface header files.
    • From: Chris Wright <[email protected]>

• Prev by Date: Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.
• Next by Date: Re: [RFC PATCH 33/35] Add the Xenbus sysfs and virtual device hotplug driver.
• Previous by thread: [RFC PATCH 04/35] Hypervisor interface header files.
• Next by thread: Re: [RFC PATCH 04/35] Hypervisor interface header files.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]