Re: [PATCH] Move various PCI IDs to header file

Grant Coady wrote:
> When I worked on pci_ids.h cleanup last year I didn't get a clear 
> idea of whether moving all #defines to the one header file was 
> desired.  Last I looked there were heaps of them scattered all 
> over.  Is there a preferred model for placing these #defines?
> 
> Grant.

According to the document Randy referenced, the preferred place for
*new* defines is to stick them in the local files where they are used.
I don't think there is any preference for moving the out of pci_ids.h
as it would just cause patch noise for the sake of making noise.

So much for being able to go through the pci_ids.h file to get an idea
about whether or not a device may have a chance of being supported :(

Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Move various PCI IDs to header file
    • From: Arjan van de Ven <[email protected]>

• References:
  • [PATCH] Move various PCI IDs to header file
    • From: Brent Casavant <[email protected]>
  • Re: [PATCH] Move various PCI IDs to header file
    • From: "Randy.Dunlap" <[email protected]>
  • Re: [PATCH] Move various PCI IDs to header file
    • From: Jes Sorensen <[email protected]>
  • Re: [PATCH] Move various PCI IDs to header file
    • From: "Randy.Dunlap" <[email protected]>
  • Re: [PATCH] Move various PCI IDs to header file
    • From: Grant Coady <[email protected]>

• Prev by Date: Re: [PATCH 1/10] make stop_machine_run accept cpumask
• Next by Date: Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
• Previous by thread: Re: [PATCH] Move various PCI IDs to header file
• Next by thread: Re: [PATCH] Move various PCI IDs to header file
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]