[PATCH] fix mem-leak in sidewinder driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In sw_connect we leak 'buf' and 'idbuf' when we do not leave via one of 
the fail* labels. This was spotted by the coverity checker.
This patch fixes the memory leak.

Patch is compile tested only due to lack of hardware.


Signed-off-by: Jesper Juhl <[email protected]>
---

 drivers/input/joystick/sidewinder.c |    2 ++
 1 files changed, 2 insertions(+)

--- linux-2.6.17-rc3-git12-orig/drivers/input/joystick/sidewinder.c	2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.17-rc3-git12/drivers/input/joystick/sidewinder.c	2006-05-07 03:57:47.000000000 +0200
@@ -776,6 +776,8 @@ static int sw_connect(struct gameport *g
 			goto fail4;
 	}
 
+	kfree(buf);
+	kfree(idbuf);
 	return 0;
 
  fail4:	input_free_device(sw->dev[i]);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux