Re: [PATCH 3/5] periodic clocksource update

[john stultz <johnstul@us.ibm.com>]

On Thu, 2006-04-27 at 23:40 +0200, Roman Zippel wrote:
> There are big differences. :)
> As I already mentioned it produces smaller code and I tried to make the 
> fast path as small as possible.
> I also updated the algorithm to be more robust, the subtle changes are in 
> the clocksource_bigadjust(), which does a bit more work to keep the clock 
> from oscillating.

Ok, I'd like to integrate the ideas from your clocksource_adjust()
method into what I currently have as make_ntp_adj().  However the code
is still difficult to grasp, for example, you have the constants 33, 32
and 31 there with no explanation of exactly why you're using differing
shift values. I'm just still really hesitant to add code that is so
difficult to read and understand. 

So I'll take another pass at optimizing my make_ntp_adj function, and
maybe you could do the same with respect to clarity and comments for
clocksource_adjust() and maybe we can meet halfway?

thanks
-john

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/