Re: [PATCH 04/13] cell: remove broken __setup_cpu_be function

Arnd Bergmann writes:

>  From: Geoff Levand <[email protected]>
> 
> This patch removes the incorrect Cell processor setup routine
> __setup_cpu_be.  This routine improperly accesses the hypervisor
> page size configuration at SPR HID6.  The correct behavior is for
> firmware, or if needed, platform setup code, to set the correct
> page size.

> -		.cpu_setup		= __setup_cpu_be,
> +		.cpu_setup		= __setup_cpu_power4,

That looks a bit dodgy.  Either just remove the contents of
__setup_cpu_be (leaving only the blr), or define a __setup_cpu_null
that does nothing, or make the identify_cpu not call the cpu setup
function if the pointer is NULL.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 04/13] cell: remove broken __setup_cpu_be function
    • From: Geoff Levand <[email protected]>

• References:
  • [PATCH 00/13] Cell patches for 2.6.18
    • From: Arnd Bergmann <[email protected]>
  • [PATCH 04/13] cell: remove broken __setup_cpu_be function
    • From: Arnd Bergmann <[email protected]>

• Prev by Date: [patch] add new uevent
• Next by Date: Re: [PATCH] device core: remove redundant call to device_initialize.
• Previous by thread: [PATCH 04/13] cell: remove broken __setup_cpu_be function
• Next by thread: Re: [PATCH 04/13] cell: remove broken __setup_cpu_be function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]