Re: [PATCH] fix x86 microcode driver handling of multiple matching revisions

>> +		for_each_online_cpu(cpu_num) {
>> +			if (ucode_cpu_info[cpu_num].mc == uci->mc) {
>> +				uci->mc = NULL;
>> +				break;
>> +			}
>
>Isn't there a memory leak here? Shouldn't this be
>		for_each_online_cpu(cpu) {
>			if (cpu == cpu_num)
>				continue;
>			if (ucode_cpu_info[cpu].mc == uci->mc) {
>				uci->mc = NULL;
>				break;
>			}
>		}

Indeed, I'll send an updated patch later.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fix x86 microcode driver handling of multiple matching revisions
    • From: "Jan Beulich" <[email protected]>
  • Re: [PATCH] fix x86 microcode driver handling of multiple matching revisions
    • From: "Siddha, Suresh B" <[email protected]>

• Prev by Date: Re: [PATCH 7/7] uts namespaces: Implement CLONE_NEWUTS flag
• Next by Date: Re: [PATCH] Fix CONFIG_PRINTK_TIME hangs on some systems
• Previous by thread: Re: [PATCH] fix x86 microcode driver handling of multiple matching revisions
• Next by thread: [PATCH, updated] fix x86 microcode driver handling of multiple matching revisions
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]