* Patrick McHardy <[email protected]> wrote: > > + /* > > + * Dont trust the initial offset: > > + */ > > + offset = skb->nh.iph->ihl * 4 + sizeof(sctp_sctphdr_t); > > + if (offset >= skb->len) > > + return 1; > > + > > That part is unnecessary, the presence of one sctp_sctphdr_t > has already been verified by skb_header_pointer() in sctp_new(). ok. > How about this patch (based on your patch, but typos fixed and also > covers nf_conntrack)? sure, fine with me! Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- From: Ingo Molnar <[email protected]>
- Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- From: Ingo Molnar <[email protected]>
- Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- From: Patrick McHardy <[email protected]>
- Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- From: Ingo Molnar <[email protected]>
- Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- From: Patrick McHardy <[email protected]>
- Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- From: Ingo Molnar <[email protected]>
- Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- From: Patrick McHardy <[email protected]>
- [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- Prev by Date: Re: [PATCH] CodingStyle: add typedefs chapter
- Next by Date: Re: Compiling C++ modules
- Previous by thread: Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- Next by thread: Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
- Index(es):
 |