Jörn Engel <[email protected]> wrote on 04/28/2006 07:47:54 PM:
> On Fri, 28 April 2006 19:37:08 +0200, Michael Holzheu wrote:
> >
> > +static void *diag204_get_buffer(enum diag204_format fmt, int *pages)
> > +{
> > + void *buf;
> > +
> > + if (fmt == INFO_SIMPLE)
> > + *pages = 1;
> > + else
> > + *pages = diag204(SUBC_RSI | fmt, 0, 0);
> > +
> > + if (*pages <= 0)
> > + return ERR_PTR(-ENOSYS);
>
> Is -ENOSYS the right thing here? I thought it was for stuff not
> implemented by Linux. If the hardware or some hypervisor would return
> -ENOSYS, it would be -EIO from Linux' perspective. But I may be
> wrong.
The only case "diag204(SUBC_RSI | fmt, 0, 0)" can fail is,
if it is not implemented by the hardware. The means
ENOSYS (Function not implemented), doen't it?
Michael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
