On Mon, 2006-05-01 at 15:51 -0700, Geoff Levand wrote: > Segher, a problem with your suggestion is that our > makefiles don't have as rich a set of logical ops as the > config files. Its easy to express 'build A if B', but not > so easy to do 'build A if not C'. To make this work > cleanly I made PPC_CELL denote !SOME_HYPERVISOR_THING, > so I can have constructions like this in the makefile: > > obj-$(CONFIG_PPC_CELL) += ... Hi Geoff, I've been ignoring this discussion, but now that I read it I think this is all kinda backwards. PPC_CELL should not denote !SOME_HYPERVISOR, it should just mean "basic cell support", ie. PPC_CELL gets you platforms/cell built in. Then we can have SOME_HYPERVISOR which _adds_ support for that hypervisor. And PPC_CELL_BLADE which selects things which are actually specific to that hardware, like SPIDERNET etc. But SOME_HYPERVISOR should not remove support for running on bare metal, it should just give you the option of running on the hypervisor. Yes that may require testing things at runtime, that's what firmware_has_feature() is for. The goal should be that we have one kernel which can boot on all Cell implementations. In fact the ultimate goal is to have one kernel that can boot any platform under powerpc, that's a way off still, but we don't want to start going backwards. cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: [Cbe-oss-dev] [PATCH 11/13] cell: split out board specificfil es
- From: Geoff Levand <[email protected]>
- Re: [Cbe-oss-dev] [PATCH 11/13] cell: split out board specificfil es
- References:
- [PATCH 00/13] Cell patches for 2.6.18
- From: Arnd Bergmann <[email protected]>
- [PATCH 11/13] cell: split out board specific files
- From: Arnd Bergmann <[email protected]>
- Re: [PATCH 11/13] cell: split out board specific files
- From: Segher Boessenkool <[email protected]>
- Re: [PATCH 11/13] cell: split out board specific files
- From: Geoff Levand <[email protected]>
- [PATCH 00/13] Cell patches for 2.6.18
- Prev by Date: Re: [Cbe-oss-dev] [PATCH 11/13] cell: split out board specific files
- Next by Date: Re: [openib-general] Re: [PATCH 2 of 13] ipath - set up 32-bit DMA mask if 64-bit setup fails
- Previous by thread: Re: [Cbe-oss-dev] [PATCH 11/13] cell: split out board specific files
- Next by thread: Re: [Cbe-oss-dev] [PATCH 11/13] cell: split out board specificfil es
- Index(es):
 |