Re: [PATCH 5 of 13] ipath - use proper address translation routine

    Bryan> Move away from an obsolete, unportable routine for
    Bryan> translating physical addresses.

This change:

 > -		isge->vaddr = bus_to_virt(sge->addr);
 > +		isge->vaddr = phys_to_virt(sge->addr);

is really wrong.  bus_to_virt() is really what you want, because in
this case the address is a bus address that came from dma_map_xxx().
You're still going to be hosed on systems with IOMMUs for example.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 5 of 13] ipath - use proper address translation routine
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 5 of 13] ipath - use proper address translation routine
    • From: Arjan van de Ven <[email protected]>

• References:
  • [PATCH 5 of 13] ipath - use proper address translation routine
    • From: "Bryan O'Sullivan" <[email protected]>

• Prev by Date: Re: [PATCH 2 of 13] ipath - set up 32-bit DMA mask if 64-bit setup fails
• Next by Date: Re: [PATCH/RFC] minix filesystem update to V3 diffed to 2.6.17-rc3
• Previous by thread: [PATCH 5 of 13] ipath - use proper address translation routine
• Next by thread: Re: [PATCH 5 of 13] ipath - use proper address translation routine
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]