Re: [PATCH 4/4] MultiAdmin module

On Mon, May 01, 2006 at 03:50:21PM +0200, Jan Engelhardt wrote:
> 
> [PATCH 4/4] MultiAdmin module
> 
>     -   Add the MultiAdmin to the mainline tree.
>         I hope the rest is self-explanatory.
> 
> Please do not mention CodingStyle for multiadm.c. I already know it. :)
> And I will get to it should it really be merged.

No one will review it if it isn't in the proper CodingStyle.

We have a coding style for a reason, it makes it a very simple thing for
anyone to review the code as the patterns are all the same.  It turns
out that people's brains get trained to ignore the patterns and see the
details instead.  Lots of research backs this up.

So switch to the common coding style, otherwise no one will look at your
code (or if they do, odds are they will miss a lot...)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
    • From: James Morris <[email protected]>
  • Re: Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
    • From: Greg KH <[email protected]>
  • Re: Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
    • From: Jan Engelhardt <[email protected]>
  • Re: Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
    • From: Arjan van de Ven <[email protected]>
  • Re: Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
    • From: Jan Engelhardt <[email protected]>
  • Re: Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
    • From: Greg KH <[email protected]>
  • Re: Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
    • From: Jan Engelhardt <[email protected]>
  • Re: Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
    • From: Greg KH <[email protected]>
  • [PATCH 0/4] MultiAdmin LSM
    • From: Jan Engelhardt <[email protected]>
  • [PATCH 4/4] MultiAdmin module
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: Re: splice(SPLICE_F_MOVE) problems
• Next by Date: Re: [PATCH 004 of 11] md: Increase the delay before marking metadata clean, and make it configurable.
• Previous by thread: Re: [PATCH 4/4] MultiAdmin module
• Next by thread: Re: [PATCH 0/4] MultiAdmin LSM
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]