Re: [PATCH]: powerpc/pseries: Print PCI slot location code on failure

Linas Vepstas writes:

> +		location = (char *) get_property(event->dn, "ibm,loc-code", NULL);
> +		printk(KERN_ERR "EEH: Error: Cannot find partition endpoint "
> +		                "for location=%s pci addr=%s\n",
> +		        location, pci_name(event->dev));

If location is NULL, printk will fortunately save us from a null
pointer dereference; still, it might be nice to have the message say
"location=unknown" or something rather than "location=<NULL>".

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH]: powerpc/pseries: Print PCI slot location code on failure
    • From: [email protected] (Linas Vepstas)

• Prev by Date: Re: [PATCH] s390: Hypervisor File System
• Next by Date: Re: [PATCH 1/3] powerpc: Make rtas console _much_ faster
• Previous by thread: [PATCH]: powerpc/pseries: Print PCI slot location code on failure
• Next by thread: PCI init vs. memory init
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]