Re: 2.6.17-rc2-mm1

[Vivek Goyal <vgoyal@in.ibm.com>]

On Fri, Apr 28, 2006 at 06:07:17PM +0200, matthieu castet wrote:
> Vivek Goyal wrote:
> >On Thu, Apr 27, 2006 at 05:47:25PM +0200, Matthieu CASTET wrote:
> >
> >
> >I think it would break on ppc64 as u64 is unsigned long. It should be
> >explicitly typecasted to unsigned long long. Same is true for all the
> >instances.
> On 64 bits platform, unsigned long isn't the same as unsigned long long ?
> 
> Do you mean there will be a warning ?

Yes.

> But pnp_printf is a variadic fonction (with no attribute format printf), 
> so gcc can't check the arguments type.
> 

You are right. I did not notice that for pnp_printf(), attribute format
printf is not specified. So gcc won't do the type checking on format string
arguments.

( __attribute__ ((format (printf, 2, 3)));

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/