Some small stuff.
On Thu, 27 April 2006 12:48:29 +0200, Heiko J Schick wrote:
>
> + * This source code is distributed under a dual license of GPL v2.0 and
> OpenIB
Line wrap. You might want to check your mailer or switch to a
different one.
> + return (-EINVAL);
Remove brackets.
> + if (H_SUCCESS != hipz_rc) {
To frown upon reversed grammar, I tend. Hard to understand, such code
is.
With a decent compiler, there is zero advantage to put the constant
first - assuming you don't ignore warnings. But it makes the code
just as hard to read as the Yoda-speak above.
> + return retcode;
People tend to use the shorter "ret" or "err".
Jörn
--
You can take my soul, but not my lack of enthusiasm.
-- Wally
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
