Re: [PATCH] change gen_pool allocator to not touch managed memory

On Wed, Apr 26, 2006 at 11:12:48AM +0200, Jes Sorensen wrote:
> > -	if (status)
> > -		printk(KERN_WARNING "smp_call_function failed for "
> > -		       "uncached_ipi_mc_drain! (%i)\n", status);
> > +	(void) smp_call_function(uncached_ipi_mc_drain, NULL, 0, 1);
> 
> This thing could in theory fail so having the error check there seems
> the right thing to me. In either case, please don't (void) the function
> return (this is a style issue, I know).

I must be blind.  Both up and smp cases for smp_call_function appear to
always return 0.  What am I missing?

Thanks,
Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] change gen_pool allocator to not touch managed memory
  - From: Jes Sorensen <[email protected]>

References:
- [PATCH] change gen_pool allocator to not touch managed memory
  - From: [email protected] (Dean Nelson)
- Re: [PATCH] change gen_pool allocator to not touch managed memory
  - From: Andrew Morton <[email protected]>
- Re: [PATCH] change gen_pool allocator to not touch managed memory
  - From: Dean Nelson <[email protected]>
- Re: [PATCH] change gen_pool allocator to not touch managed memory
  - From: Jes Sorensen <[email protected]>

Prev by Date: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
Next by Date: What's in git.git
Previous by thread: Re: [PATCH] change gen_pool allocator to not touch managed memory
Next by thread: Re: [PATCH] change gen_pool allocator to not touch managed memory
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]