Re: [patch 3/3] use kref for bio

On Wed, Apr 26, 2006 at 07:13:44AM +0200, Jens Axboe wrote:
> On Wed, Apr 26 2006, Al Viro wrote:
> > On Wed, Apr 26, 2006 at 10:11:02AM +0800, Akinobu Mita wrote:
> > > Use kref for reference counter of bio.
> > > This patch also removes BUG_ON() for freeing unreferenced bio.
> > > But kref can detect it if CONFIG_DEBUG_SLAB is enabled.
> >  
> > *Ugh*
> > 
> > Let's _not_.  It's extra overhead for no good reason.
> 
> Completely agree. That goes for the other block layer kref patches as
> well.

I also agree, there's a reason I never tried to convert them in the past
:)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 3/3] use kref for bio
    • From: Akinobu Mita <[email protected]>

• References:
  • [patch 0/3] use kref
    • From: Akinobu Mita <[email protected]>
  • [patch 3/3] use kref for bio
    • From: Akinobu Mita <[email protected]>
  • Re: [patch 3/3] use kref for bio
    • From: Al Viro <[email protected]>
  • Re: [patch 3/3] use kref for bio
    • From: Jens Axboe <[email protected]>

• Prev by Date: Re: [patch 1/3] use kref for blk_queue_tag
• Next by Date: Re: [PATCH] Direct I/O bio size regression
• Previous by thread: Re: [patch 3/3] use kref for bio
• Next by thread: Re: [patch 3/3] use kref for bio
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]