Re: [patch 2/2] kref: kref debugging config option

On Tue, Apr 25, 2006 at 04:21:39PM +0800, Akinobu Mita wrote:
> -	WARN_ON(atomic_read(&kref->refcount) < 1);
> -	WARN_ON(release == NULL);
> -	WARN_ON(release == (void (*)(struct kref *))kfree);

No, those two last WARN_ON() are not "debugging" checks, they are
"checks for people trying to do bad things with kref code".  I always
want them "on", as there should not be any excuse for anyone to do this.

So I don't think this patch is needed at all.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 0/2] kref debugging (retry)
    • From: Akinobu Mita <[email protected]>
  • [patch 2/2] kref: kref debugging config option
    • From: Akinobu Mita <[email protected]>

• Prev by Date: Re: [PATCH] sched: fix evaluation of skip_for_load in move_tasks()
• Next by Date: Re: [patch 1/2] kref: detect kref_put() with unreferenced object
• Previous by thread: [patch 2/2] kref: kref debugging config option
• Next by thread: RT_PREEMPT, nfsd and reboot.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]