Re: [PATCH 8 of 13] ipath - fix a number of RC protocol bugs

"Bryan O'Sullivan" <[email protected]> wrote:
>
> +	BUG_ON(qp->timerwait.next != LIST_POISON1);
>  +	list_add_tail(&qp->timerwait, &dev->pending[dev->pending_index]);

Please don't play around with list_head internals like this - some
speedfreak might legitimately choose to remove the list_head poisoning
debug code, or make it Kconfigurable.

One option would be to always do list_del_init() on this thing, then do
BUG_ON(!list_empty()).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 8 of 13] ipath - fix a number of RC protocol bugs
    • From: Roland Dreier <[email protected]>

• References:
  • [PATCH 0 of 13] ipath - various fixes and cleanups
    • From: "Bryan O'Sullivan" <[email protected]>
  • [PATCH 8 of 13] ipath - fix a number of RC protocol bugs
    • From: "Bryan O'Sullivan" <[email protected]>

• Prev by Date: Re: Compiling C++ modules
• Next by Date: Re: [PATCH/RFC] s390: Hypervisor File System
• Previous by thread: [PATCH 8 of 13] ipath - fix a number of RC protocol bugs
• Next by thread: Re: [PATCH 8 of 13] ipath - fix a number of RC protocol bugs
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]