On Mon, 2006-04-24 at 19:19 +0200, Michael Holzheu wrote:
> +#ifndef __HAVE_ARCH_STRRTRIM
> +/**
> + * strrtrim - Remove trailing characters specified in @reject
> + * @s: The string to be searched
> + * @reject: The string of letters to avoid
> + */
> +void strrtrim(char *s, const char *reject)
I think this should return s to be consistent with other string API
functions.
> +{
> + char *p;
> + const char *r;
You need to exit here if strlen(s) is zero.
> +
> + for (p = s + strlen(s) - 1; s <= p; p--) {
> + for (r = reject; (*r != '\0') && (*p != *r); r++)
> + /* nothing */;
Please use strchr for the above.
> + if (*r == '\0')
> + break;
What are you testing here?
> + }
> + *(p + 1) = '\0';
> +}
> +EXPORT_SYMBOL(strrtrim);
> +#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
