Re: [patch 2/4] kref debugging config option

On Tue, Apr 25, 2006 at 12:53:37PM +0800, Akinobu Mita wrote:
> On Mon, Apr 24, 2006 at 02:38:45PM -0700, Andrew Morton wrote:
> > Akinobu Mita <[email protected]> wrote:
> > >
> > > This patch converts all WARN_ON() in kref code to BUG_ON().
> > 
> > Why?  This change will irritate testers and will decrease their ability to
> > capture (and hence report) diagnostic info.
> 
> I have no grudge against this BUG_ON().
> 
> But BUG_ON() is more prominent than WARN_ON().

Sure, it crashes your kernel, hopefully you notice that better :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 0/4] kref debugging
    • From: Akinobu Mita <[email protected]>
  • [patch 2/4] kref debugging config option
    • From: Akinobu Mita <[email protected]>
  • Re: [patch 2/4] kref debugging config option
    • From: Andrew Morton <[email protected]>
  • Re: [patch 2/4] kref debugging config option
    • From: Akinobu Mita <[email protected]>

• Prev by Date: Re: [patch 1/4] kref: warn kref_put() with unreferenced kref
• Next by Date: Re: [patch 1/4] kref: warn kref_put() with unreferenced kref
• Previous by thread: Re: [patch 2/4] kref debugging config option
• Next by thread: Re: [patch 2/4] kref debugging config option
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]