Re: [PATCH 3/3] Assert notifier_block and notifier_call are not in init section

On Mon, 24 Apr 2006, [email protected] wrote:
> 
> 	Feel free to drop this patch if you think it is not needed.

It's incorrect.

The init section will be free'd, and as a result can be re-allocated to 
other uses. Thus testing that data is not in the init-section makes no 
sense.

Testing for _code_ not being in the init section can be sensible, since 
code never gets re-allocated (modulo module code, but that's never in the 
init section). So checking the "notifier_call" part may be sensible, but 
checking the notifier block data pointer definitely is not.

Patches 1-2 applied.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 3/3] Assert notifier_block and notifier_call are not in init section
  - From: Chandra Seetharaman <[email protected]>
- Re: [PATCH 3/3] Assert notifier_block and notifier_call are not in init section
  - From: Linus Torvalds <[email protected]>

References:
- [PATCH 0/3] Fix for the bug reported by Herbert on 2.6.17-rc2
  - From: [email protected]
- [PATCH 3/3] Assert notifier_block and notifier_call are not in init section
  - From: [email protected]

Prev by Date: Re: [PATCH] sched: Fix boolean expression in move_tasks()
Next by Date: Re: [PATCH] sched: Fix boolean expression in move_tasks()
Previous by thread: [PATCH 3/3] Assert notifier_block and notifier_call are not in init section
Next by thread: Re: [PATCH 3/3] Assert notifier_block and notifier_call are not in init section
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]