Re: [PATCH 1/1] threads_max: Simple lockout prevention patch

Pekka Enberg wrote:
> On 4/24/06, Al Boldi <[email protected]> wrote:
> > Like so?
> >         if (nr_threads >= max_threads)
> >                 if (p->pid != su_pid)
> >                         goto bad_fork_cleanup_count;
>
> It's better to combine the two if statements into one with &&.

I thought of combining them too, but was afraid of some compile optimization 
issues.  Remember, this code-path is executed for each and every fork in the 
system, thus it's highly performance sensitive.

Thanks!

--
Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/1] threads_max: Simple lockout prevention patch
    • From: Pekka Enberg <[email protected]>

• References:
  • Re: [PATCH 1/1] threads_max: Simple lockout prevention patch
    • From: Al Boldi <[email protected]>
  • Re: [PATCH 1/1] threads_max: Simple lockout prevention patch
    • From: "Pekka Enberg" <[email protected]>

• Prev by Date: Re: Time to remove LSM (was Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks)
• Next by Date: RE: Problems with EDAC coexisting with BIOS
• Previous by thread: Re: [PATCH 1/1] threads_max: Simple lockout prevention patch
• Next by thread: Re: [PATCH 1/1] threads_max: Simple lockout prevention patch
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]